Skip to content

Update readme and the Makefile to remove outdated instructions and adjust the local test timeouts #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Update readme and the Makefile to remove outdated instructions and adjust the local test timeouts #667

merged 1 commit into from
Mar 11, 2025

Conversation

2000krysztof
Copy link

@2000krysztof 2000krysztof commented Feb 27, 2025 •
edited
Loading

Issue link

Jira : https://issues.redhat.com/browse/RHOAIENG-19986

What changes have been made

Verification steps

Please go through the instructions in the readme.

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • Testing is not required for this change

@openshift-ci openshift-ci bot requested review from Bobbins228 and dimakis February 27, 2025 14:25
Bobbins228
Bobbins228 requested changes Feb 27, 2025
View reviewed changes
@Bobbins228
Copy link
Contributor

@2000krysztof You are failing on the pre-commit I would recommend installing it and running pre-commit run --all-files before each commit to ensure your work falls in line with our linting standards :) .

@ChristianZaccaria ChristianZaccaria changed the title WIP : Update readme and the Makefile to remove outdated instructions and adjust the local test timeouts Update readme and the Makefile to remove outdated instructions and adjust the local test timeouts Mar 7, 2025
Ygnas
Ygnas requested changes Mar 10, 2025
View reviewed changes
ChristianZaccaria
ChristianZaccaria requested changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the instructions on running the e2e test locally!

Bobbins228
Bobbins228 approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@Bobbins228 Bobbins228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm /approve

@openshift-ci openshift-ci bot added lgtm and removed lgtm labels Mar 10, 2025
@Bobbins228
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 10, 2025
ChristianZaccaria
ChristianZaccaria requested changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the last requested change, and should be good to merge.

As step 3. in the Readme:

  1. Build, push, and deploy the codeflare-operator.
  make image-push IMG=<full-registry>:<tag>
  make deploy -e IMG=<full-registry>:<tag> -e ENV="e2e"

@openshift-ci openshift-ci bot removed the lgtm label Mar 11, 2025
@2000krysztof
Update outdated README.md, update Makefile commands to support local …
016b71b 
…kind test, upgrade kindest/node to 1.30.10 .
ChristianZaccaria
ChristianZaccaria approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@ChristianZaccaria ChristianZaccaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
Thank you!

Ygnas
Ygnas approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@Ygnas Ygnas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobbins228, ChristianZaccaria, Ygnas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b612ce3 into project-codeflare:main Mar 11, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ygnas Ygnas Ygnas approved these changes

@Bobbins228 Bobbins228 Bobbins228 approved these changes

@ChristianZaccaria ChristianZaccaria ChristianZaccaria approved these changes

@dimakis dimakis Awaiting requested review from dimakis

Assignees

@Ygnas Ygnas

@Bobbins228 Bobbins228

@ChristianZaccaria ChristianZaccaria

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2000krysztof @Bobbins228 @Ygnas @ChristianZaccaria